Fix meson-build global_arguments #4698
Open
+161
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amibranch
requested review from
wargio,
XVilka,
kazarmy,
thestr4ng3r and
ret2libc
as code owners
amibranch
force-pushed
the
dist-add_subproject_test
branch
2 times, most recently
from
6d82baa
to
84398aa
Compare
amibranch
force-pushed
the
dist-add_subproject_test
branch
10 times, most recently
from
99f8713
to
93b6425
Compare
amibranch
commented
Nov 3, 2024
.github/workflows/subproject.yml
Outdated
| - name: Replace branch in wrap-file | ||
| run: | | ||
| # NOTE: This is a workaround, as meson wrap files cannot be used on remote tracking | ||
| git checkout -b ${{ github.ref_name }} |
There was a problem hiding this comment.
To any reviewer: My github-workflow experience is quite limited. I'm therefore not sure, if this workaround is also functional and sufficient in the "push"-case (i.e. what is github.ref_name in such a case)?
Any experience, or suggestions are highly appreciated!
wargio
reviewed
Nov 4, 2024
* Added a CI-task to check if rizin could be used as subproject * Fixed some new global-arguments in meson-build
amibranch
force-pushed
the
dist-add_subproject_test
branch
from
93b6425
to
f1a7a18
Compare
wargio
reviewed
Nov 6, 2024
| # TODO: extend to perform actually linking test as well! | ||
| tester_source = custom_target('main.c', | ||
| command: ['echo', ''' | ||
| #include <stdio.h> |
There was a problem hiding this comment.
maybe add rz_core.h instead of stdio.h and call rz_cons_printf
wargio
requested changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
It happened again...
This makes it (again) impossible to add rizin as subproject.
Test plan
To avoid any further regressions, a CI-Task is proposed herein.
The task really just tests if it is possible to use a branch/PR of rizin as subproject. It (currently) wouldn't check for any linker-problems or API-stability as there is no such guaranty in that setup.
Closing issues
Partially addresses #3454
Also: